Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional limit to the maximum size of the relay catchup buffer #1873

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Add an optional limit to the maximum size of the relay catchup buffer #1873

merged 2 commits into from
Sep 20, 2023

Conversation

PlasmaPower
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 19, 2023
lambchr
lambchr reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@lambchr lambchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, just curious about the maxCatchup param

broadcaster/sequencenumbercatchupbuffer.go Show resolved Hide resolved
lambchr
lambchr approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@lambchr lambchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

joshuacolvin0
joshuacolvin0 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit b359dbc into master Sep 20, 2023
@PlasmaPower PlasmaPower deleted the relay-max-catchup branch September 20, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambchr lambchr lambchr approved these changes

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PlasmaPower @joshuacolvin0 @lambchr